Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem: fix error handling #36856

Merged
merged 2 commits into from
Aug 7, 2020
Merged

filesystem: fix error handling #36856

merged 2 commits into from
Aug 7, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 30, 2020

walkdir: fix thrown error location and types and performance

  • previously the error for the root path would be handled differently than any other error, and errors from isdir would not be passed to the onerror hook
  • previously we'd recurse heavily through multiple channels, but there's no reason to do that

readdir: fix thrown error code on some OS

  • previously might report the wrong error code (usually just always resulting in saying "unknown error", on e.g. Windows)

seek: fix thrown error code on Windows

  • previously would just print a random error reason

@vtjnash vtjnash added the filesystem Underlying file system and functions that use it label Jul 30, 2020
walkdir: fix thrown error location and types and performance
readdir: fix thrown error code on some OS
seek: fix thrown error code on Windows
@vtjnash vtjnash merged commit dffc889 into master Aug 7, 2020
@vtjnash vtjnash deleted the jn/_walkdir branch August 7, 2020 15:04
KristofferC pushed a commit that referenced this pull request Aug 10, 2020
walkdir: fix thrown error location and types and performance
readdir: fix thrown error code on some OS
seek: fix thrown error code on Windows
(cherry picked from commit dffc889)
@KristofferC KristofferC mentioned this pull request Aug 10, 2020
25 tasks
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
walkdir: fix thrown error location and types and performance
readdir: fix thrown error code on some OS
seek: fix thrown error code on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem Underlying file system and functions that use it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants