Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #28188: filename lost in cmd interpolation #37007

Merged
merged 2 commits into from
Aug 12, 2020
Merged

fix #28188: filename lost in cmd interpolation #37007

merged 2 commits into from
Aug 12, 2020

Conversation

simeonschaub
Copy link
Member

Didn't really know where else to put this test, can certainly move this somewhere else,
fixes #28188, fixes #37005

@Keno
Copy link
Member

Keno commented Aug 11, 2020

Didn't really know where else to put this test, can certainly move this somewhere else,

test/misc.jl is fine

Keno
Keno approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should probably have a way to represent a full parse position (e.g. to give error messages while parsing interpolated expressions), but this is good in the meantime.

@StefanKarpinski StefanKarpinski changed the title fix 28188: filename lost in cmd interpolation fix #28188: filename lost in cmd interpolation Aug 12, 2020
@Keno Keno merged commit 06b7f0b into JuliaLang:master Aug 12, 2020
This was referenced Aug 13, 2020
Closed
Open
Closed
@KristofferC KristofferC mentioned this pull request Aug 13, 2020
Merged
25 tasks
KristofferC pushed a commit that referenced this pull request Aug 13, 2020
@simeonschaub @KristofferC
fix #28188: filename lost in cmd interpolation (#37007)
e438d0e 
* fix 28188: filename lost in cmd interpolation

* move test to test/misc.jl

(cherry picked from commit 06b7f0b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro __source__ information lost in Cmd interpolation Interpolation of __FILE__ into cmd
4 participants
@simeonschaub @Keno @KristofferC @fredrikekre