Fix type of allocated array when broadcasting type unstable function #37028
Conversation
We need to call similar on the `Broadcasted` object rather than on dest array. Otherwise the `BroadcastStyle` isn't taken into account when allocating new array due to function returning elements of different types.
| fprod(aa) = aa .* aa' | ||
| @test a .+ 1 == @inferred(fadd(aa)) | ||
| @test a .+ 1 .* 2 == @inferred(fadd2(aa)) | ||
| @test a .* a' == @inferred(fprod(aa)) | ||
| @test isequal(a .+ [missing; 1:9], fadd3(aa)) | ||
| @test_broken Core.Compiler.return_type(fadd3, (typeof(aa),)) <: Array19745{<:Union{Float64, Missing}} |
|
Ah, this makes sense. So the destination is initially created with: Subsequent widenings had previously been but that privileges the initial |
|
Any chance somebody could trip over this? Maybe a NEWS item? |
|
I don't think it should surprise anybody. If this changes the behavior for you, then you obtained different array (container) types depending on whether your function returned elements of the same type or not. Package authors that experienced this are more likely to have worked around this by defining |
…uliaLang#37028) We need to call similar on the `Broadcasted` object rather than on dest array. Otherwise the `BroadcastStyle` isn't taken into account when allocating new array due to function returning elements of different types.
We need to call similar on the
Broadcastedobject rather than on dest array. Otherwise theBroadcastStyleisn't taken into account when allocating new array due to function returning elements of different types.See #36106 (comment).