Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INNO_ARGS makefile var for signtool #37236

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

musm
Copy link
Contributor

@musm musm commented Aug 27, 2020

@staticfloat

Signing now works when I add the following to my Make.user

override INNO_ARGS=/Dsign=true "/Smysigntool=\$$q`cygpath -w /cygdrive/c/Program\ Files\ \(x86\)/Windows\ Kits/10/bin/10.0.19041.0/x64/signtool.exe`\$$q sign /f \$$q`cygpath -w /cygdrive/c/Users/Mus/Code/julia/mycert.pfx`\$$q /p Pass123 \$$f"

In simplified terms

override INNO_ARGS=/Dsign=true "/Smysigntool=\$$q`cygpath -w {{signtool path}}`\$$q sign /f \$$q`cygpath -w {{certificate path}}`\$$q /p {{certificate password}} \$$f"

Yes it's kind of a total mess, but we can't help it since this is going through like 3 layers of path/filename translations: makefiles, cygwin, and inno....

@fredrikekre fredrikekre added building Build system, or building Julia or its dependencies system:windows Affects only Windows labels Aug 27, 2020
@staticfloat
Copy link
Member

Great! This is perfect.

@staticfloat staticfloat merged commit 05a0d54 into JuliaLang:master Aug 27, 2020
@musm
Copy link
Contributor Author

musm commented Aug 27, 2020

Great. BTW do these makefile vars default to empty strings if not defined? I was contemplating whether we needed to define them in Make.inc

@musm musm deleted the nsis-sign branch August 27, 2020 17:21
@staticfloat
Copy link
Member

Yes, they default to empty.

simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 29, 2020
KristofferC pushed a commit that referenced this pull request Oct 21, 2020
@KristofferC KristofferC mentioned this pull request Oct 21, 2020
15 tasks
@vchuravy vchuravy mentioned this pull request Jan 21, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants