Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code coverage fixes #37243

Merged
merged 2 commits into from
Sep 1, 2020
Merged

code coverage fixes #37243

merged 2 commits into from
Sep 1, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 27, 2020

No description provided.

@vtjnash
restore explicit module field to LineNumberNode
42a1d34 
While this takes a non-trivial amount of space in the system image
(about the same as putting the Method object here, but less than putting
the full edge to the MethodInstance), it is necessary to avoid the
regression #36462 caused by 2e37784.
@vtjnash
coverage: ensure definition line is also counted
8aaf971 
Closes #36825
@vtjnash vtjnash merged commit 949caad into master Sep 1, 2020
@vtjnash vtjnash deleted the jn/36462+36825 branch September 1, 2020 16:25
@vtjnash vtjnash mentioned this pull request Sep 1, 2020
Merged
@yuyichao yuyichao mentioned this pull request Sep 5, 2020
Closed
@KristofferC KristofferC mentioned this pull request Sep 7, 2020
Merged
29 tasks
@KristofferC KristofferC mentioned this pull request Oct 21, 2020
Merged
15 tasks
@vchuravy vchuravy mentioned this pull request Jan 21, 2021
Merged
27 tasks
@IanButterworth
Copy link
Member

How were the changes to the the good test file coverage_file.info generated here? Was it updated by hand to be an ideal target?

Generally, I'm trying to get a handle on what's known about the reason for the misses, to figure out #44593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjnash @IanButterworth