Add in_sysimage(pkgid::PkgId) to check if a package is in the sysimage #37652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Sep 18, 2020
Co-authored-by: Takafumi Arakaki <takafumi.a@gmail.com>
|
I think this is good to go once we have some tests (in and not in stdlib). |
tkf
added
needs tests
|
@KristofferC Do you think it works (i.e., |
Probably, yes. In theory, it should be possible to set this variable once and for all before the sysimage is written, so there is no work at runtime, but that might be more trouble than it is worth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
in_sysimage(pkgid::PkgId)for checking if a package is in the sysimage.Proposed as the correct-est way to filter out packages that definitely won't need precompiling, in JuliaLang/Pkg.jl#2021
Discussed here JuliaLang/Pkg.jl#2018 (comment)
cc. @tkf @fredrikekre