Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getfield_tfunc for PartialStruct with Vararg #37769

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

martinholters
Copy link
Member

Add an unwrapva to ensure the returned type is not a Vararg. Fixes #37638.

Add an `unwrapva` to ensure the returned type is not a `Vararg`.
@martinholters martinholters added bugfix This change fixes an existing bug compiler:inference Type inference labels Sep 26, 2020
@martinholters
Copy link
Member Author

Test failures are #37735 and #37731.

@JeffBezanson JeffBezanson merged commit 22b5d93 into master Sep 28, 2020
@JeffBezanson JeffBezanson deleted the mh/fix_37638 branch September 28, 2020 17:33
@martinholters martinholters mentioned this pull request Oct 22, 2020
15 tasks
KristofferC pushed a commit that referenced this pull request Oct 22, 2020
Add an `unwrapva` to ensure the returned type is not a `Vararg`.

(cherry picked from commit 22b5d93)
Sacha0 pushed a commit that referenced this pull request Oct 23, 2020
Add an `unwrapva` to ensure the returned type is not a `Vararg`.

(cherry picked from commit 22b5d93)
@vchuravy vchuravy mentioned this pull request Jan 21, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error with TypeError and context "non-final parameter"
3 participants