[build system]: Fix USE_SYSTEM_LIBM=1 build
#37832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we started preloading `libm.so`, we neglected to take into account the name and location of `libm.so` when `USE_SYSTEM_LIBM=1` is used. This should fix it on all systems except for Ubuntu, which has an `ld` linker script instead of an actual library for `libm.so`, which has never worked.
staticfloat
force-pushed
the
sf/use_system_libm
branch
from
8e7f556 to
c50cff6
Compare
Note that this is still broken.
That's the entire point of using system library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we started preloading
libm.so, we neglected to take into accountthe name and location of
libm.sowhenUSE_SYSTEM_LIBM=1is used.This should fix it on all systems except for Ubuntu, which has an
ldlinker script instead of an actual library for
libm.so, which hasnever worked.
@yuyichao this should fix the
libm.soissues you were seeing on your build. I imagine we will need to do something forlibgcc_sas well, as you said that you don't get alibgcc_so.so.1copied into your$(JULIAHOME)/usr. That surprises me a little, as it means that there may be no compiler support libraries bundled with Julia, which means thatcontrib/fixup-libgfortran.shprobably isn't doing its job at all. This in turn means that the Julia build is entirely unportable; so not fatal, but certainly not the kind of build we like to create.