Note Set is not ordered #37850
Closed
Note Set is not ordered #37850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
approved these changes
Feb 6, 2021
vtjnash
reviewed
Apr 21, 2021
| @@ -17,6 +17,8 @@ Set() = Set{Any}() | |||
| Construct a [`Set`](@ref) of the values generated by the given iterable object, or an | |||
| empty set. Should be used instead of [`BitSet`](@ref) for sparse integer sets, or | |||
| for sets of arbitrary objects. | |||
| !!! note | |||
| Iteration over `Set` is unordered. | |||
There was a problem hiding this comment.
I would say that the iteration is ordered, but that the order is unspecified.
But seems like the bigger issue here is that we don't define what a "Set" is. I think the Dict docstring is a better model for the text here.
Set([itr]) <: AbstractSet
Construct an unordered collection of unique values as a `Set`. Values are compared with [`isequal`](@ref) and hashed with [`hash`](@ref).
Given a single iterable argument, constructs a `Set` whose values are generated by the object.
This type should be used instead of [`BitSet`](@ref) for sparse integer sets, or
for sets of arbitrary objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #23269