Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loading]: Rework preferences loading #38044

Merged
merged 1 commit into from
Oct 27, 2020
Merged

[loading]: Rework preferences loading #38044

merged 1 commit into from
Oct 27, 2020

Commits on Oct 19, 2020

  1. [loading]: Rework preferences loading

    Implements the `Preferences` loading framework as outlined in [0]. The
    most drastic change is that the list of compile-time preferences is no
    longer sequestered within its own dictionary, but is instead
    autodetected at compile-time and communicated back to the compiler.
    This list of compile-time preferences is now embedded as an array of
    strings that the loader must load, then index into the preferences
    dictionary with that list to check the preferences hash.
    
    In a somewhat bizarre turn of events, because we want the `.ji` filename
    to incorporate the preferences hash, and because we can't know how to
    generate the hash until after we've precompiled, I had to move the `.ji`
    filename generation step to _after_ we precompile the `.ji` file.
    
    [0]: #37791 (comment)
    staticfloat committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    c9aba74 View commit details
    Browse the repository at this point in the history