Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Bidiagonal represents empty matrix #38392

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Permit Bidiagonal represents empty matrix #38392

merged 1 commit into from
Dec 9, 2020

Conversation

KlausC
Copy link
Contributor

@KlausC KlausC commented Nov 11, 2020

Closes JuliaLang/LinearAlgebra.jl#782

Allows empty Bidiagonal to be constructed and tweaks the corner case in a few operations.
Added extensive test cases.

@KlausC
Copy link
Contributor Author

KlausC commented Nov 11, 2020

Unfortunately this seems to be a sibling of PR #38384 - sorry I did not recognize.
This one seems more complete, though.

@dkarrasch
Copy link
Member

Let's rerun CI and merge if tests pass (or fail unrelatedly).

@dkarrasch dkarrasch closed this Dec 9, 2020
@dkarrasch dkarrasch reopened this Dec 9, 2020
@dkarrasch dkarrasch added merge me PR is reviewed. Merge when all tests are passing backport 1.6 Change should be backported to release-1.6 and removed merge me PR is reviewed. Merge when all tests are passing labels Dec 9, 2020
@dkarrasch
Copy link
Member

The usual unrelated test failures.

@dkarrasch dkarrasch merged commit 293e60c into JuliaLang:master Dec 9, 2020
KristofferC pushed a commit that referenced this pull request Dec 14, 2020
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinearAlgebra: Bidiagonal should support empty matrices
3 participants