Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compat for mktemp and mktempdir docstrings #38452

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Add compat for mktemp and mktempdir docstrings #38452

merged 2 commits into from
Nov 30, 2020

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Nov 15, 2020 •
edited
Loading

X-refs: #32851 for cleanup and #31230 for prefix

@mortenpi mortenpi changed the title Add compat entries for mktemp and mktempdir Add compat for mktemp and mktempdir docstrings Nov 15, 2020
@dkarrasch dkarrasch added the docs This change adds or pertains to documentation label Nov 16, 2020
StefanKarpinski
StefanKarpinski approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My bad for not writing compat strings in the docs when I changed these.

@mortenpi
Copy link
Contributor Author

Bump for merge 🙂

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label Nov 30, 2020
@KristofferC KristofferC reopened this Nov 30, 2020
@fredrikekre
Copy link
Member

Is CI not running on merge commit?

@fredrikekre fredrikekre merged commit bc94c50 into JuliaLang:master Nov 30, 2020
@mortenpi mortenpi deleted the patch-4 branch December 3, 2020 23:13
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mortenpi @fredrikekre @StefanKarpinski @KristofferC @DilumAluthge @dkarrasch