fix Meta.partially_inline! for ReturnNode #38519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IR change happend in #36318 |
|
Ah, just noticed we need to recurse into |
vchuravy
approved these changes
Nov 21, 2020
simeonschaub
added a commit
that referenced
this pull request
Jan 6, 2021
forgot to take `statement_offset` into account in #38519
KristofferC
pushed a commit
that referenced
this pull request
Jan 6, 2021
forgot to take `statement_offset` into account in #38519
KristofferC
pushed a commit
that referenced
this pull request
Jan 6, 2021
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
forgot to take `statement_offset` into account in JuliaLang#38519
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta.partially_inline!currently doesn't recurse intoReturnNodes, which is important for IRTools, for example. Is this the correct solution here?