-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify documentation for view
to take into account range special case
#38536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added a suggestion but I don't think that's a hard requirement.
Co-authored-by: Takafumi Arakaki <takafumi.a@gmail.com>
Looks like this changed in 1.5, for anyone else wondering. The PR was #26872.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I got carried away. I've never been thrilled with defining view()
as taking a view.
This is a suggested wholesale reworking of the text; please see what you think.
Co-authored-by: Matt Bauman <mbauman@gmail.com>
Co-authored-by: Matt Bauman <mbauman@gmail.com>
Co-authored-by: Matt Bauman <mbauman@gmail.com>
Co-authored-by: Takafumi Arakaki <takafumi.a@gmail.com>
view
sometimes does not return aSubArray
, e.g.,This is not really consistent with the docstring for
view
. So this PR modifies the docstring.Cf JuliaArrays/FillArrays.jl#84 where we want to do something similar with FillArrays.jl but want to make sure it's justified.