literal type pointers #3870
Closed
literal type pointers #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I will rebase #3625 and try this tonight! |
|
Ah, I see. Never mind my question on the other commit. |
|
I'm not sure if it's necessary to have this special-case code for types, since this needs to be applicable to all uses of literal_pointer_val. Maybe just a lookup table mapping addresses to global symbol names. |
|
I was experimenting to see what would be necessary. I think you're right that the table approach is going to be necessary for the general case. @ihnorton I like the enthusiasm, but this won't fix static compilation by itself. |
KristofferC
pushed a commit
that referenced
this pull request
May 2, 2024
Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 8f772ffa7 New commit: a0851bcfd Julia version: 1.12.0-DEV Pkg version: 1.12.0 Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@8f772ff...a0851bc ``` $ git log --oneline 8f772ffa7..a0851bcfd a0851bcfd Relax overly-specific manifest tests (#3884) 299b77093 guard against isdir EACESS in completions (#3877) b9c39a7be Merge pull request #3883 from JuliaLang/kc/resolve_tree_hash 8ab562f72 instantiate the test environment if it is in the current workspace when testing 1d961c1c9 get the correct manifest file for a workspace e468facb5 allow `resolve` to download packages that have been deleted from disk but has a manifest entry 20ceec9b8 do not precompile full env on `using` callback from REPL (#3876) 195e17e3f Replace UnstableIO with IOContext{IO} (#3735) 00aa38cb3 add missing `**5.**` (#3870) ac5672dad Revert "Move "Creating Packages" to Julia docs" (#3818) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
…#54316) Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 8f772ffa7 New commit: a0851bcfd Julia version: 1.12.0-DEV Pkg version: 1.12.0 Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@8f772ff...a0851bc ``` $ git log --oneline 8f772ffa7..a0851bcfd a0851bcfd Relax overly-specific manifest tests (JuliaLang#3884) 299b77093 guard against isdir EACESS in completions (JuliaLang#3877) b9c39a7be Merge pull request JuliaLang#3883 from JuliaLang/kc/resolve_tree_hash 8ab562f72 instantiate the test environment if it is in the current workspace when testing 1d961c1c9 get the correct manifest file for a workspace e468facb5 allow `resolve` to download packages that have been deleted from disk but has a manifest entry 20ceec9b8 do not precompile full env on `using` callback from REPL (JuliaLang#3876) 195e17e3f Replace UnstableIO with IOContext{IO} (JuliaLang#3735) 00aa38cb3 add missing `**5.**` (JuliaLang#3870) ac5672dad Revert "Move "Creating Packages" to Julia docs" (JuliaLang#3818) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces literal_pointer_val( jl_type_t* ) with something that is hopefully more friendly to static compilation.