[Make] remove BINARYBUILDER_LLVM_ASSERTS and use LLVM_ASSERTIONS instead

[vchuravy]

Marked as a draft since the assert binaries are older than the current release binaries.

@staticfloat is currently building those manually and building them automatically involves JuliaPackaging/BinaryBuilder.jl#778 (comment) and JuliaPackaging/BinaryBuilder.jl#917

CI is still set-up to run LLVM_ASSERTIONS=1 so this fixes #38244

[vchuravy]

And indeed we are hitting assertion errors:

 cd /buildworker/worker/package_linux64/build/base && /buildworker/worker/package_linux64/build/usr/bin/julia -C "generic;sandybridge,-xsaveopt,clone_all;haswell,-rdrnd,base(1)" --output-ji /buildworker/worker/package_linux64/build/usr/lib/julia/corecompiler.ji.tmp --startup-file=no --warn-overwrite=yes -g0 -O0 compiler/compiler.jl
Expected<T> must be checked before access or destruction.
Expected<T> value was in success state. (Note: Expected<T> values in success mode must still be checked prior to being destroyed).
/bin/sh: line 1:  3509 Aborted                 (core dumped) /buildworker/worker/package_linux64/build/usr/bin/julia -C "generic;sandybridge,-xsaveopt,clone_all;haswell,-rdrnd,base(1)" --output-ji /buildworker/worker/package_linux64/build/usr/lib/julia/corecompiler.ji.tmp --startup-file=no --warn-overwrite=yes -g0 -O0 compiler/compiler.jl
make[1]: *** [/buildworker/worker/package_linux64/build/usr/lib/julia/corecompiler.ji] Error 134
make: *** [julia-sysimg-ji] Error 2
make[1]: Leaving directory `/buildworker/worker/package_linux64/build'

[vtjnash]

Looks like we solved all Julia errors, now we're just hitting one inside GlobalISel for linuxaarch64

[vchuravy]

The dream is not alive:

      From worker 3:	julia: /workspace/srcdir/llvm-project/llvm/lib/IR/Instructions.cpp:455: void llvm::CallInst::init(llvm::FunctionType*, llvm::Value*, llvm::ArrayRef<llvm::Value*>, llvm::ArrayRef<llvm::OperandBundleDefT<llvm::Value*> >, const llvm::Twine&): Assertion `(i >= FTy->getNumParams() || FTy->getParamType(i) == Args[i]->getType()) && "Calling a function with a bad signature!"' failed.
      From worker 3:	
      From worker 3:	signal (6): Aborted
      From worker 3:	in expression starting at /buildworker/worker/tester_linuxaarch64/build/share/julia/test/keywordargs.jl:321
      From worker 3:	gsignal at /lib/aarch64-linux-gnu/libc.so.6 (unknown line)
      From worker 3:	abort at /lib/aarch64-linux-gnu/libc.so.6 (unknown line)
      From worker 3:	Allocations: 548533655 (Pool: 547962150; Big: 571505); GC: 884

[Keno]

Blocked by https://bugs.llvm.org/show_bug.cgi?id=48661 is my understanding?

[vchuravy]

Blocked by https://bugs.llvm.org/show_bug.cgi?id=48661 is my understanding?

Yes and whatever causes (on AArch64):

      From worker 10:	Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly signext sret zeroext byval(half) preallocated(half) dereferenceable(1) dereferenceable_or_null(1)
      From worker 10:	  %639 = call half inttoptr (i64 281472804681464 to half (i32, float, double, half)*)(i32 %623, float %628, double %636, half zeroext %638) [ "jl_roots"({} addrspace(10)* %176, {} addrspace(10)* %174, {} addrspace(10)* %172, {} addrspace(10)* %170) ], !dbg !19
      From worker 10:	Wrong types for attribute: inalloca nest noalias nocapture nonnull readnone readonly signext sret zeroext byval(half) preallocated(half) dereferenceable(1) dereferenceable_or_null(1)
      From worker 10:	  %700 = call [2 x i64] inttoptr (i64 281472804681520 to [2 x i64] (i32, float, double, half)*)(i32 %684, float %689, double %697, half zeroext %699) [ "jl_roots"({} addrspace(10)* %670, {} addrspace(10)* %668, {} addrspace(10)* %666, {} addrspace(10)* %664) ], !dbg !38
      From worker 10:	julia: /workspace/srcdir/llvm-project/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2369: llvm::slpvectorizer::BoUpSLP::~BoUpSLP(): Assertion `!verifyFunction(*F, &dbgs())' failed.
      From worker 10:	
      From worker 10:	signal (6): Aborted
      From worker 10:	in expression starting at /buildworker/worker/tester_linuxaarch64/build/share/julia/test/ccall.jl:1151
      From worker 10:	gsignal at /lib/aarch64-linux-gnu/libc.so.6 (unknown line)
      From worker 10:	abort at /lib/aarch64-linux-gnu/libc.so.6 (unknown line)
      From worker 10:	Allocations: 289993769 (Pool: 289871907; Big: 121862); GC: 366

[vchuravy]

Fixes #38775 (comment)

[vchuravy]

Merged into the staging branch for LLVM 11.0.1.