Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated ldiv! method in qr.jl #38801

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix duplicated ldiv! method in qr.jl #38801

merged 1 commit into from
Dec 9, 2020

Conversation

Keno
Copy link
Member

@Keno Keno commented Dec 9, 2020

Introduced in #38389

@dkarrasch
Copy link
Member

Wait, why? One is for QR, the other for QRPivoted. What am I missing?

@Keno
Copy link
Member Author

Keno commented Dec 9, 2020

See the method just above it.

@dkarrasch
Copy link
Member

🤦 above... below... it all depends. 😂

@Keno
Copy link
Member Author

Keno commented Dec 9, 2020

github's diff view can be misleading that way, because the method above is cut off.

@dkarrasch dkarrasch added backport 1.6 Change should be backported to release-1.6 linear algebra Linear algebra labels Dec 9, 2020
@Keno Keno merged commit d6f9948 into master Dec 9, 2020
@Keno Keno deleted the kf/qrdedup branch December 9, 2020 22:23
@KristofferC KristofferC mentioned this pull request Dec 11, 2020
53 tasks
KristofferC pushed a commit that referenced this pull request Dec 11, 2020
Introduced in #38389

(cherry picked from commit d6f9948)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants