Commits on Dec 14, 2020

1. LibGit2: improve error when CA root cert can't be set …

   This also fixes an insecure behavior: even if `set_ssl_cert_locations`
   failed, `REFCOUNT` was still incremented, which meant that subsequent
   calls to `ensure_initialized` didn't call `initialize` and so there was
   never a successful call to `set_ssl_cert_locations`. Without this
   libgit2 defaults to not verifying host identities and that is insecure.
   To prevent this, this patch locks on `ensure_initialized` and decrements
   `REFCOUNT` if initialize throws an error, ensuring that `initialize`
   succeeds at least once, including the call to `set_ssl_cert_locations`.

   

   StefanKarpinski committed Dec 14, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 9b4b9c7
   • Browse repository at this point

   Copy the full SHA

   9b4b9c7 View commit details

   Browse the repository at this point in the history