Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ccall to git_libgit2_opts as variadic #38852

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Mark ccall to git_libgit2_opts as variadic #38852

merged 1 commit into from
Dec 17, 2020

Conversation

vchuravy
Copy link
Member

Fixes #38638, as usual PPC is sensitive to variadic functions. Correctly done in LibGit2.set_ssl_cert_locations.

@vchuravy vchuravy added backport 1.6 Change should be backported to release-1.6 system:powerpc PowerPC labels Dec 12, 2020
@KristofferC KristofferC mentioned this pull request Dec 14, 2020
Merged
53 tasks
@vtjnash
Copy link
Member

vtjnash commented Dec 15, 2020

@ccall supports more features (including varargs) that ccall doesn't support

@vchuravy vchuravy force-pushed the vc/libgit2_va branch 2 times, most recently from f6cfd5d to 1c24ed0 Compare December 17, 2020 21:20
@vchuravy vchuravy merged commit e2cf172 into master Dec 17, 2020
@vchuravy vchuravy deleted the vc/libgit2_va branch December 17, 2020 23:24
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno left review comments

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
system:powerpc PowerPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PPC] double free or corruption in libgit
4 participants
@vchuravy @vtjnash @Keno @KristofferC