-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DEPOT_PATH instead of HOME in cmdlineargs test #38855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
test
This change adds or pertains to unit tests
backport 1.6
Change should be backported to release-1.6
labels
Dec 12, 2020
vchuravy
force-pushed
the
vc/cmdlineargs
branch
from
December 12, 2020 19:42
8079f82
to
72459f4
Compare
StefanKarpinski
approved these changes
Dec 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely clear what these tests are testing, but if this works then it seems better than artificially changing the home directory.
vchuravy
force-pushed
the
vc/cmdlineargs
branch
from
December 12, 2020 20:00
72459f4
to
9b89ce5
Compare
Still seeming some failure locally so I will investigate further:
|
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2020
(cherry picked from commit 8f2b0e7)
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
(cherry picked from commit 8f2b0e7)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 8f2b0e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running test with a custom
JULIA_DEPOT_PATH
set and I noticed that thecmdlineargs
test were failing.julia/base/client.jl
Line 317 in b3eaa34
HOME
as a default path but rather the user depot.