Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DEPOT_PATH instead of HOME in cmdlineargs test #38855

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Conversation

vchuravy
Copy link
Member

I was running test with a custom JULIA_DEPOT_PATH set and I noticed that the cmdlineargs test were failing.

!isempty(DEPOT_PATH) && include_ifexists(Main, abspath(DEPOT_PATH[1], "config", "startup.jl"))
is not using HOME
as a default path but rather the user depot.

@vchuravy vchuravy added test This change adds or pertains to unit tests backport 1.6 Change should be backported to release-1.6 labels Dec 12, 2020
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely clear what these tests are testing, but if this works then it seems better than artificially changing the home directory.

@vchuravy
Copy link
Member Author

Still seeming some failure locally so I will investigate further:

Test Failed at /nobackup/users/vchuravy/dev/julia/test/cmdlineargs.jl:468
  Expression: readchomp(`$exename --startup-file=yes -e 'exit(0)' -- foo -bar --baz`) == output
   Evaluated: "" == "[\"foo\", \"-bar\", \"--baz\"]"
Test Failed at /nobackup/users/vchuravy/dev/julia/test/cmdlineargs.jl:473
  Expression: readchomp(`$exename --startup-file=yes $testfile`) == output
   Evaluated: "String[]" == "String[]\nString[]"
Test Failed at /nobackup/users/vchuravy/dev/julia/test/cmdlineargs.jl:514
  Expression: readsplit(`$exename --startup-file=yes -e 'exit(0)'`) == [c, ""]
   Evaluated: SubString{String}[""] == ["/tmp/jl_K4T6Rg/.julia/config/startup.jl", ""]
Test Failed at /nobackup/users/vchuravy/dev/julia/test/cmdlineargs.jl:516
  Expression: readsplit(`$exename --startup-file=yes -L $b -e 'exit(0)'`) == [c, "", b, ""]
   Evaluated: SubString{String}["/tmp/jl_K4T6Rg/b.jl", ""] == ["/tmp/jl_K4T6Rg/.julia/config/startup.jl", "", "/tmp/jl_K4T6Rg/b.jl", ""]
Test Failed at /nobackup/users/vchuravy/dev/julia/test/cmdlineargs.jl:519
  Expression: readsplit(`$exename --startup-file=yes -L $b $a`) == [c, a, b, a, a, a, b, a]
   Evaluated: SubString{String}["/tmp/jl_K4T6Rg/b.jl", "/tmp/jl_K4T6Rg/a.jl", "/tmp/jl_K4T6Rg/a.jl", "/tmp/jl_K4T6Rg/a.jl", "/tmp/jl_K4T6Rg/b.jl", "/tmp/jl_K4T6Rg/a.jl"] == ["/tmp/jl_K4T6Rg/.julia/config/startup.jl", "/tmp/jl_K4T6Rg/a.jl"
, "/tmp/jl_K4T6Rg/b.jl", "/tmp/jl_K4T6Rg/a.jl", "/tmp/jl_K4T6Rg/a.jl", "/tmp/jl_K4T6Rg/a.jl", "/tmp/jl_K4T6Rg/b.jl", "/tmp/jl_K4T6Rg/a.jl"]

@vchuravy vchuravy marked this pull request as ready for review December 12, 2020 21:14
@vchuravy vchuravy merged commit 8f2b0e7 into master Dec 13, 2020
@vchuravy vchuravy deleted the vc/cmdlineargs branch December 13, 2020 00:55
@KristofferC KristofferC mentioned this pull request Dec 14, 2020
53 tasks
KristofferC pushed a commit that referenced this pull request Dec 14, 2020
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants