Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clobber rax in x86_64 trampoline #38882

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Don't clobber rax in x86_64 trampoline #38882

merged 1 commit into from
Dec 15, 2020

Conversation

Keno
Copy link
Member

@Keno Keno commented Dec 14, 2020

rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause jl_ to print nonsense.

rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause `jl_` to print nonsense.
@vchuravy vchuravy added the backport 1.6 Change should be backported to release-1.6 label Dec 14, 2020
@Keno Keno added the ci Continuous integration label Dec 14, 2020
@Keno
Copy link
Member Author

Keno commented Dec 14, 2020

Should fix occasional CI failures on FreeBSD.

@staticfloat staticfloat merged commit b376982 into master Dec 15, 2020
@staticfloat staticfloat deleted the kf/r11 branch December 15, 2020 00:10
KristofferC pushed a commit that referenced this pull request Dec 17, 2020
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause `jl_` to print nonsense.

(cherry picked from commit b376982)
@KristofferC KristofferC mentioned this pull request Dec 17, 2020
53 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause `jl_` to print nonsense.

(cherry picked from commit b376982)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause `jl_` to print nonsense.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause `jl_` to print nonsense.

(cherry picked from commit b376982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants