Don't clobber rax in x86_64 trampoline #38882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between functions. Messing with rax here can cause `jl_` to print nonsense.
|
Should fix occasional CI failures on FreeBSD. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 17, 2020
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between functions. Messing with rax here can cause `jl_` to print nonsense. (cherry picked from commit b376982)
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between functions. Messing with rax here can cause `jl_` to print nonsense. (cherry picked from commit b376982)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between functions. Messing with rax here can cause `jl_` to print nonsense.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between functions. Messing with rax here can cause `jl_` to print nonsense. (cherry picked from commit b376982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rax is used to pass vararg metadata. r11 can be used for dynamic linker shenanigans between
functions. Messing with rax here can cause
jl_to print nonsense.