-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct pcre2-cet-flags.patch whitespace. #38913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcre2-cet-flags.patch lacks some trailing whitespace that exists in one of the target files. Consequently, the patch does not apply when the patch tool is strict about whitespace. This teensy diff makes the whitespace in pcre2-cet-flags.patch strictly match the whitespace in the target file. Co-Authored-By: Nathan Daly <NHDaly@gmail.com>
Sacha0
added
building
Build system, or building Julia or its dependencies
bugfix
This change fixes an existing bug
backport 1.6
Change should be backported to release-1.6
labels
Dec 16, 2020
I'll believe you on that one ;) |
KristofferC
pushed a commit
that referenced
this pull request
Dec 17, 2020
pcre2-cet-flags.patch lacks some trailing whitespace that exists in one of the target files. Consequently, the patch does not apply when the patch tool is strict about whitespace. This teensy diff makes the whitespace in pcre2-cet-flags.patch strictly match the whitespace in the target file. Co-Authored-By: Nathan Daly <NHDaly@gmail.com> Co-authored-by: Nathan Daly <NHDaly@gmail.com> (cherry picked from commit 3853060)
I wouldn't 😄. Trust, but verify 😉. Thanks for the rapid review and merge Keno! :) |
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
pcre2-cet-flags.patch lacks some trailing whitespace that exists in one of the target files. Consequently, the patch does not apply when the patch tool is strict about whitespace. This teensy diff makes the whitespace in pcre2-cet-flags.patch strictly match the whitespace in the target file. Co-Authored-By: Nathan Daly <NHDaly@gmail.com> Co-authored-by: Nathan Daly <NHDaly@gmail.com> (cherry picked from commit 3853060)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
pcre2-cet-flags.patch lacks some trailing whitespace that exists in one of the target files. Consequently, the patch does not apply when the patch tool is strict about whitespace. This teensy diff makes the whitespace in pcre2-cet-flags.patch strictly match the whitespace in the target file. Co-Authored-By: Nathan Daly <NHDaly@gmail.com> Co-authored-by: Nathan Daly <NHDaly@gmail.com>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
pcre2-cet-flags.patch lacks some trailing whitespace that exists in one of the target files. Consequently, the patch does not apply when the patch tool is strict about whitespace. This teensy diff makes the whitespace in pcre2-cet-flags.patch strictly match the whitespace in the target file. Co-Authored-By: Nathan Daly <NHDaly@gmail.com> Co-authored-by: Nathan Daly <NHDaly@gmail.com> (cherry picked from commit 3853060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @NHDaly