Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pcre2-cet-flags.patch whitespace. #38913

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Dec 16, 2020

pcre2-cet-flags.patch lacks some trailing whitespace that exists in
one of the target files. Consequently, the patch does not apply when
the patch tool is strict about whitespace.

This teensy diff makes the whitespace in pcre2-cet-flags.patch
strictly match the whitespace in the target file.

Co-Authored-By: Nathan Daly <NHDaly@gmail.com>

cc @NHDaly

pcre2-cet-flags.patch lacks some trailing whitespace that exists in
one of the target files. Consequently, the patch does not apply when
the patch tool is strict about whitespace.

This teensy diff makes the whitespace in pcre2-cet-flags.patch
strictly match the whitespace in the target file.

Co-Authored-By: Nathan Daly <NHDaly@gmail.com>
@Sacha0 Sacha0 added building Build system, or building Julia or its dependencies bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 labels Dec 16, 2020
@Keno
Copy link
Member

Keno commented Dec 17, 2020

I'll believe you on that one ;)

@Keno Keno merged commit 3853060 into master Dec 17, 2020
@Keno Keno deleted the sv-nhd-pcre-patch-patch branch December 17, 2020 02:08
KristofferC pushed a commit that referenced this pull request Dec 17, 2020
pcre2-cet-flags.patch lacks some trailing whitespace that exists in
one of the target files. Consequently, the patch does not apply when
the patch tool is strict about whitespace.

This teensy diff makes the whitespace in pcre2-cet-flags.patch
strictly match the whitespace in the target file.

Co-Authored-By: Nathan Daly <NHDaly@gmail.com>

Co-authored-by: Nathan Daly <NHDaly@gmail.com>
(cherry picked from commit 3853060)
@KristofferC KristofferC mentioned this pull request Dec 17, 2020
53 tasks
@Sacha0
Copy link
Member Author

Sacha0 commented Dec 17, 2020

I'll believe you on that one ;)

I wouldn't 😄. Trust, but verify 😉.

Thanks for the rapid review and merge Keno! :)

@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
pcre2-cet-flags.patch lacks some trailing whitespace that exists in
one of the target files. Consequently, the patch does not apply when
the patch tool is strict about whitespace.

This teensy diff makes the whitespace in pcre2-cet-flags.patch
strictly match the whitespace in the target file.

Co-Authored-By: Nathan Daly <NHDaly@gmail.com>

Co-authored-by: Nathan Daly <NHDaly@gmail.com>
(cherry picked from commit 3853060)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
pcre2-cet-flags.patch lacks some trailing whitespace that exists in
one of the target files. Consequently, the patch does not apply when
the patch tool is strict about whitespace.

This teensy diff makes the whitespace in pcre2-cet-flags.patch
strictly match the whitespace in the target file.

Co-Authored-By: Nathan Daly <NHDaly@gmail.com>

Co-authored-by: Nathan Daly <NHDaly@gmail.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
pcre2-cet-flags.patch lacks some trailing whitespace that exists in
one of the target files. Consequently, the patch does not apply when
the patch tool is strict about whitespace.

This teensy diff makes the whitespace in pcre2-cet-flags.patch
strictly match the whitespace in the target file.

Co-Authored-By: Nathan Daly <NHDaly@gmail.com>

Co-authored-by: Nathan Daly <NHDaly@gmail.com>
(cherry picked from commit 3853060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants