Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the need for disabling BB if building without network access #38918

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Document the need for disabling BB if building without network access #38918

merged 2 commits into from
Dec 17, 2020

Conversation

ViralBShah
Copy link
Member

Fix #33569

@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label Dec 17, 2020
DilumAluthge
DilumAluthge approved these changes Dec 17, 2020
View reviewed changes
doc/build/build.md Outdated Show resolved Hide resolved
@Keno @DilumAluthge
Update doc/build/build.md
babdf28 
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@Keno
Copy link
Member

Keno commented Dec 17, 2020

This seems fine, but should we ship that as a default Make.user in the -full tarballs?

@DilumAluthge
Copy link
Member

I think there was some disagreement about that in #33569

I think as a first step, it's sufficient to just update the documentation.

@Keno
Copy link
Member

Keno commented Dec 17, 2020

Well, I'm glad I'm consistent in my opinions at least.

@ViralBShah ViralBShah merged commit 9c2d813 into master Dec 17, 2020
@ViralBShah ViralBShah deleted the vs/firewall branch December 17, 2020 14:33
@ViralBShah ViralBShah added the backport 1.6 Change should be backported to release-1.6 label Dec 17, 2020
KristofferC pushed a commit that referenced this pull request Dec 18, 2020
@ViralBShah @KristofferC
Document the need for disabling BB if building without network access (…
f90e2f3 
…#38918)

* Document the need for disabling BB if building without network access

Fix #33569

* Update doc/build/build.md

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

Co-authored-by: Keno Fischer <keno@juliacomputing.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
(cherry picked from commit 9c2d813)
@KristofferC KristofferC mentioned this pull request Dec 18, 2020
Merged
53 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
@ViralBShah @staticfloat
Document the need for disabling BB if building without network access (…
a380013 
…#38918)

* Document the need for disabling BB if building without network access

Fix #33569

* Update doc/build/build.md

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

Co-authored-by: Keno Fischer <keno@juliacomputing.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
(cherry picked from commit 9c2d813)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@ViralBShah @Keno
@DilumAluthge @ElOceanografo
Document the need for disabling BB if building without network access (…
9758104 
…JuliaLang#38918)

* Document the need for disabling BB if building without network access

Fix JuliaLang#33569

* Update doc/build/build.md

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

Co-authored-by: Keno Fischer <keno@juliacomputing.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@ViralBShah @staticfloat
Document the need for disabling BB if building without network access (…
e286959 
…#38918)

* Document the need for disabling BB if building without network access

Fix #33569

* Update doc/build/build.md

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

Co-authored-by: Keno Fischer <keno@juliacomputing.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
(cherry picked from commit 9c2d813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

julia-1.2.0-full.tar.gz does not build behind firewall
4 participants
@ViralBShah @Keno @DilumAluthge @KristofferC