Fixes so that test suite can run in more tightly sandboxed environment #39101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't assume that `stdlib` is in a writable location; always download temporary testing files to `$TMPDIR`.
Instead of writing out to actual `$HOME`, create a temporary directory and set that as `$HOME`/`$USERPROFILE`.
staticfloat
changed the title
Sacha0
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't assume that we have write permissions everywhere; the home directory, the
stdlibdirectory, etc... should not be written to during our test suite. This PR adjusts things to more consistently write out to$TMPDIRinstead of other places, and this enables running the test suite inside of tightened sandbox such as the one constructed here: https://github.com/staticfloat/MacOSSandboxExperiments/