fix #39218, bug in subtyping fast path for tuples with repeated elements #39237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
types and dispatch
vtjnash
approved these changes
Jan 13, 2021
Keno
approved these changes
Jan 14, 2021
|
Does this cause any major compile/runtime regressions? |
|
What makes you believe that? Did you try something out? |
|
Based on a quick look at the PR, I assumed that it was restricting the use of a fast path for type equality. I didn't observe regressions, I was just trying to understand if it was expected that there would be any. |
|
You will get the right answer slower than you used to get the potentially wrong answer ;). I doubt it'll have a major impact though. |
KristofferC
pushed a commit
that referenced
this pull request
Jan 19, 2021
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #39218
This bug seems to go all the way back to v0.6.