bugfixes for showing type aliases #39366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you had 2 aliases that both matched, we might print
```S{T} where T (alias for S{T} where T)```
which is clearly unnecessary.
Always a bit more compact in this form, and somewhat easier to implement too (thus keeping this consistent with the corrected typealias printing).
vtjnash
added
bugfix
| @@ -554,7 +555,7 @@ function make_typealias(@nospecialize(x::Type)) | |||
| for name in names(mod) | |||
| if isdefined(mod, name) && !isdeprecated(mod, name) && isconst(mod, name) | |||
| alias = getfield(mod, name) | |||
| if alias isa Type && !has_free_typevars(alias) && !isvarargtype(alias) && !print_without_params(alias) && x <: alias | |||
There was a problem hiding this comment.
Should this change be removed for the backport to 1.6?
There was a problem hiding this comment.
Yes, this commit can be ignored for the backport
JeffBezanson
approved these changes
Jan 25, 2021
|
Only tangentially related, but is it worth considering memoization? Or is it not worth the 265-risk? #36263 (comment) |
|
We probably should do some, since this otherwise is hammering runtime reflection pretty hard. It doesn't really matter if the information is stale, as long as it remains reasonable. Some of the string output might have module prefixes (in the parameters), so we would want to cache before that point. Perhaps an IdDict mapping from Type{T} -> GlobalRef? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some cases where the
whereclause we print would be incorrect in some way. This alters the printing to prefer the compact form of where (with {}`), and ensures it prints the environments correctly.