Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linux unwind info stop, per x86_64 ABI #39400

Merged
merged 2 commits into from
Jan 27, 2021
Merged

fix linux unwind info stop, per x86_64 ABI #39400

merged 2 commits into from
Jan 27, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 26, 2021

On amd64, terminating unwind requires RBP to be NULL (undefined). On most other platforms, unwinding instead stops when the instruction pointer becomes NULL (undefined). This lead to double-counting the number of profile frames, and other similar anomalous behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant