Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinearAlgebra] Add libblas and liblapack bindings in again #39845

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

staticfloat
Copy link
Member

Some packages use these; rather than create unnecesary package churn,
let's just define them again and add a note that serious applications
should use the much richer detail available from BLAS.get_config().

Some packages use these; rather than create unnecesary package churn,
let's just define them again and add a note that serious applications
should use the much richer detail available from `BLAS.get_config()`.
@ViralBShah
Copy link
Member

The NNlib.jl breakage arises from it passing BLAS.libblas to ccall to have access to more BLAS functions. So the right thing for that kind of use case is to literally just use libblastrampoline as the library.

@ViralBShah ViralBShah added the linear algebra Linear algebra label Feb 27, 2021
@ViralBShah ViralBShah merged commit bcc0ea1 into master Feb 27, 2021
@ViralBShah ViralBShah deleted the sf/linalg_libblas_liblapack branch February 27, 2021 02:34
@lkapelevich
Copy link
Contributor

liblapack was defined in LinearAlgebra.LAPACK and this defines it in LinearAlgebra.BLAS, was that intentional?

@fredrikekre
Copy link
Member

Probably not.

@ViralBShah
Copy link
Member

Yeah, probably just needs to be in LinearAlgebra.LAPACK. @lkapelevich Would you be able to submit a PR?

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
…aLang#39845)

Some packages use these; rather than create unnecesary package churn,
let's just define them again and add a note that serious applications
should use the much richer detail available from `BLAS.get_config()`.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
…aLang#39845)

Some packages use these; rather than create unnecesary package churn,
let's just define them again and add a note that serious applications
should use the much richer detail available from `BLAS.get_config()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants