Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct lyap definition for complex scalar arguments #39901

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Correct lyap definition for complex scalar arguments #39901

merged 3 commits into from
Mar 16, 2021

Conversation

Regan-Koopmans
Copy link
Contributor

@Regan-Koopmans Regan-Koopmans commented Mar 3, 2021

This PR resolves #39857

As per @sethaxen 's demonstration, the definition of lyap is incorrect for complex scalar arguments. The definition has. been updated in accordance with his recommendation.

@Keno
Copy link
Member

Keno commented Mar 4, 2021

Welcome. This could additionally use a test to make sure that this doesn't regress.

@Keno Keno added the needs tests Unit tests are required for this change label Mar 4, 2021
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this seems to require commutativity, and may fail for Quaternions. As a slight generalization, I don't see why we need to require equal types for a and c.

stdlib/LinearAlgebra/src/dense.jl Outdated Show resolved Hide resolved
@Keno Keno removed the needs tests Unit tests are required for this change label Mar 5, 2021
Copy link
Contributor

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@dkarrasch dkarrasch merged commit da96fef into JuliaLang:master Mar 16, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lyap is incorrect for complex scalar arguments
4 participants