Use roundeven
instead of rint
for round(x)
#40514
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
llvm.rint
intrinsic is sensitive to the floating-pointenvironment, so determined enough users can change the definition
of
round(x, RoundNearest)
to not be rount to even.The intrinsic was introduced with LLVM 11, and
roundeven
will be partof the
C23
standard (problematic for us due toruntime_intrinsics.cpp
).Sadly performance isn't looking to hot. Using @simonbyrne benchmark from
#8750 (comment)
On x86:
e.g it's implemented with a function call to
roundevenf64
, which is implemented by libc.