-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rational division by zero #40551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sostock
reviewed
Apr 21, 2021
sostock
added
backport 1.6
Change should be backported to release-1.6
bugfix
This change fixes an existing bug
labels
Apr 21, 2021
The test failures are due to the type-instability (before this PR, the |
Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
sostock
reviewed
Apr 21, 2021
sostock
reviewed
Apr 21, 2021
Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
simonbyrne
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
KristofferC
pushed a commit
that referenced
this pull request
May 4, 2021
* Fix rational division by zero * Replace `BigFloat` by `BigInt` Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com> (cherry picked from commit 2307f80)
45 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Fix rational division by zero * Replace `BigFloat` by `BigInt` Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Fix rational division by zero * Replace `BigFloat` by `BigInt` Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* Fix rational division by zero * Replace `BigFloat` by `BigInt` Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Fix rational division by zero * Replace `BigFloat` by `BigInt` Co-authored-by: Sebastian Stock <42280794+sostock@users.noreply.github.com> (cherry picked from commit 2307f80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Julia v1.5.3:
On Julia v1.6.0
It seems the line was not covered by tests so the PR both fixes the error and adds some tests.
Note that the behavior is still different from Julia v1.5.3 but there is no error and it seems to be the behavior intended by @simonbyrne in #38520