Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore performance of hash for BigInt and Rational{BigInt} #40881

Merged
merged 1 commit into from
May 20, 2021
Merged

restore performance of hash for BigInt and Rational{BigInt} #40881

merged 1 commit into from
May 20, 2021

Conversation

rfourquet
Copy link
Member

When the code was moved out of hashing2.jl, some imports where missed,
cancelling the benefits of #33790.

@rfourquet
restore performance of hash for BigInt and Rational{BigInt}
3ed4b9a 
When the code was moved out of hashing2.jl, some imports where missed,
cancelling the benefits of #33790.
@rfourquet rfourquet added performance Must go faster bignums BigInt and BigFloat hashing backport 1.6 Change should be backported to release-1.6 labels May 19, 2021
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label May 19, 2021
@dkarrasch dkarrasch merged commit c4ee1fa into master May 20, 2021
@dkarrasch dkarrasch deleted the rf/hash-bigint branch May 20, 2021 06:34
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label May 21, 2021
@KristofferC KristofferC mentioned this pull request Jun 4, 2021
Merged
45 tasks
@KristofferC
Copy link
Member

some imports where missed,

bild

KristofferC pushed a commit that referenced this pull request Jun 4, 2021
@rfourquet @KristofferC
restore performance of hash for BigInt and Rational{BigInt} (#4…
d4bca99 
…0881)

When the code was moved out of hashing2.jl, some imports where missed,
cancelling the benefits of #33790.

(cherry picked from commit c4ee1fa)
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
@rfourquet
restore performance of hash for BigInt and Rational{BigInt} (Ju…
0945dd7 
…liaLang#40881)

When the code was moved out of hashing2.jl, some imports where missed,
cancelling the benefits of JuliaLang#33790.
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@rfourquet @johanmon
restore performance of hash for BigInt and Rational{BigInt} (Ju…
d0229a6 
…liaLang#40881)

When the code was moved out of hashing2.jl, some imports where missed,
cancelling the benefits of JuliaLang#33790.
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@rfourquet @staticfloat
restore performance of hash for BigInt and Rational{BigInt} (#4…
c272b95 
…0881)

When the code was moved out of hashing2.jl, some imports where missed,
cancelling the benefits of #33790.

(cherry picked from commit c4ee1fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
bignums BigInt and BigFloat hashing performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfourquet @KristofferC @vtjnash @simeonschaub @dkarrasch