Return rhs in ldiv! for SVD and add a test #41083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
test
stevengj
reviewed
Jun 4, 2021
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
stevengj
approved these changes
Jun 4, 2021
|
Was a109558 already included in some backport branch? Not that we have a fix for the fix without the fix. 🤣 |
|
No. That one hasn't been backported. I think it might be easier to just backport this one and resolve the conflict but I'm not sure. |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
45 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jun 10, 2021
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu> (cherry picked from commit d9d59a9)
KristofferC
pushed a commit
that referenced
this pull request
Jun 10, 2021
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu> (cherry picked from commit d9d59a9)
fredrikekre
pushed a commit
that referenced
this pull request
Jun 14, 2021
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu> (cherry picked from commit d9d59a9)
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Co-authored-by: Steven G. Johnson <stevenj@alum.mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the fix for JuliaLang/LinearAlgebra.jl#853 in a109558 was only partial. This one should fix it completely.