Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdlib JLLs: add Test to the list of test-only dependencies #41239

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Stdlib JLLs: add Test to the list of test-only dependencies #41239

merged 1 commit into from
Jun 16, 2021

Conversation

DilumAluthge
Copy link
Member

AFAICT, all of the stdlib JLLS use Test in their test suite. But many of them don't actually list Test in the list of test-only dependencies. This PR fixes that.

@DilumAluthge DilumAluthge added the test This change adds or pertains to unit tests label Jun 16, 2021
@DilumAluthge DilumAluthge mentioned this pull request Jun 16, 2021
Closed
staticfloat
staticfloat approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@staticfloat staticfloat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happened because I added tests for these JLLs manually, after they had been "imported/rewritten" from the actual JLLs that exist in the wild (which do not have tests)

@DilumAluthge DilumAluthge merged commit dd94ceb into master Jun 16, 2021
@DilumAluthge DilumAluthge deleted the dpa/test-dependencies branch June 16, 2021 17:36
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@DilumAluthge @johanmon
Stdlib JLLs: add Test to the list of test-only dependencies (JuliaL…
15abd45 
…ang#41239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
JLLs test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @staticfloat