Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unwrapping-wrapping combination in LinearAlgebra #41252

Merged
merged 4 commits into from
Jun 19, 2021
Merged

Avoid unwrapping-wrapping combination in LinearAlgebra #41252

merged 4 commits into from
Jun 19, 2021

Conversation

dkarrasch
Copy link
Member

These changes should all be non-functional:

  • avoid the pattern A = adja.parent; adjoint(A)
  • shorten transA to tA to reduce line length
  • remove a few more redundant mul!/* methods

@dkarrasch dkarrasch changed the title Avoid useless unwrapping-wrapping combination in LinearAlgebra Avoid unwrapping-wrapping combination in LinearAlgebra Jun 17, 2021
oscardssmith
oscardssmith approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@oscardssmith oscardssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes! I love being able to remove 100 lines of mess!

@dkarrasch dkarrasch added the linear algebra Linear algebra label Jun 18, 2021
@dkarrasch dkarrasch merged commit ae1b469 into master Jun 19, 2021
@dkarrasch dkarrasch deleted the dk/wrapunwrap branch June 19, 2021 16:21
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@dkarrasch @johanmon
Avoid unwrapping-wrapping combination in LinearAlgebra (JuliaLang#41252)
6eeac68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarrasch @oscardssmith