Backports for 1.7-beta2 #41254
Merged
Backports for 1.7-beta2 #41254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 15c19c8)
Co-authored-by: Dilum Aluthge <dilum@aluthge.com> (cherry picked from commit 752ac81)
1. `seed!(rng::Xoshiro, seed::NTuple{4,UInt64})` and
`seed!(rng::TaskLocalRNG, seed::NTuple{4,UInt64})` were doing almost the same thing;
factor out what was identical;
2. `seed!(rng::Union{TaskLocalRNG, Xoshiro})` was calling the above methods passing
a random tuple generated by `RandomDevice`: in this case, we don't really need
to hash the seed, as it's presumably random enough; so use the same algorithm
as in `Xoshiro()` constructor, and let `Xoshiro()` re-use this new implementation
of `seed!`.
(cherry picked from commit e35028a)
(cherry picked from commit 82ae530)
(cherry picked from commit 3f27f88)
(cherry picked from commit fe94fbd)
At least the newly added field `rcondv` may contain `undef` values, so these can cause the same eigen factorizations not to compare equal. Not 100% sure whether the other fields should be ignored as well, but since we didn't have them before, it seems at least consistent to ignore them here. fixes JuliaDiff/ChainRules.jl#422 (cherry picked from commit bc3ce48)
* Add support for at-overlay with parametric function definitions. * Fix error message with at-MethodTable. * Fix function signature to avoid compiler warning. (cherry picked from commit 27ef9e0)
(cherry picked from commit 9a9e5a3)
(cherry picked from commit e34c77b)
|
@nanosoldier |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
KristofferC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
@atomic a.x = y#41216 - Fix escaping of rhs for@atomic a.x = yshow(::SparseMatrixCSC)more consistent #41150 - makeshow(::SparseMatrixCSC)more consistenthvncat: Extended docstring, reorganized helper methods, more consistent error throwing #41195 -hvncat: Extended docstring, reorganized helper methods, more consistent error throwingin(x, ::AbstractRange)forNaN/Inf#41169 - Fixin(x, ::AbstractRange)forNaN/Infhvncat: enable concatenations to return an array of the same kind #41194 -hvncat: enable concatenations to return an array of the same kindRational{T}constructor for abstractT#41229 - FixRational{T}constructor for abstractTNon-merged PRs with backport label:
hvncat: Better handling of 0- and 1-length dims/shape args #41197 -hvncat: Better handling of 0- and 1-length dims/shape argshvncat: Stronger argument checks #41196 -hvncat: Stronger argument checks