Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmp argument from replacefield! docstring #41282

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

jpsamaroo
Copy link
Member

cmp is apparently a leftover from earlier iterations of the atomics PR.

@vtjnash

@jpsamaroo
Copy link
Member Author

It'd probably be good to have this in 1.7 to prevent confusion.

@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing backport 1.7 labels Jun 19, 2021
@dkarrasch dkarrasch removed the merge me PR is reviewed. Merge when all tests are passing label Jun 20, 2021
@dkarrasch dkarrasch merged commit 153f908 into JuliaLang:master Jun 20, 2021
@jpsamaroo jpsamaroo deleted the jps/replacefield-no-cmp branch June 20, 2021 15:58
KristofferC pushed a commit that referenced this pull request Jun 26, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants