-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inability to find support/{platform,dirpath}.h from julia_fasttls.h. #41308
Conversation
This only works because we add That being said, I'm okay with this, how about you @vtjnash? |
Indeed :).
FWIW I share your preference. Happy to go with whichever you and other folks collectively prefer :). |
We probably should restructure our headers so that the public ones (this and julia.h) are the only visible ones, and the rest are tucked away somewhere, but this seems reasonable for now |
Cheers, it sounds like we would all prefer to restructure the headers at some point, but this patch does the trick for now. That being the case, I'll merge this patch to get things working pending some future restructuring. Thanks for reviewing gentlemen! :) |
Taken from JuliaLang/julia#41308, this is necessary in order to actually build C code against libjulia.
Taken from JuliaLang/julia#41308, this is necessary in order to actually build C code against libjulia.
Taken from JuliaLang/julia#41308, this is necessary in order to actually build C code against libjulia.
During PackageCompiler.jl system image creation under Julia 1.7, gcc complains that it cannot find
support/{platform,dirpath}.h
included fromjulia_fasttls.h
(while looking inusr/include/julia
). My (potentially incorrect) working understanding is that all ofjulia_fasttls.h
and{platform,dirpath}.h
end up directly inusr/include/julia
--- i.e. thesupport/
qualification ofsupport/{platform,dirpath}.h
effectively gets flattened away when{platform,dirpath}.h
are copied fromsrc/support/{platform,dirpath}.h
tousr/include/julia
. This patch drops thesupport/
qualification in the include injulia_fasttls.h
, which locally seems to make everything happy (though I imagine this may not be the best or even a generally correct approach). Best! :)