[Tasks] Mark parent as sticky if we use @async
#41334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
backport 1.7
multithreading
Fixes #41324 for 1.7
vtjnash
approved these changes
Jun 23, 2021
| parent = Threads.@spawn begin | ||
| @test current_task().sticky == false | ||
| child = @async begin end | ||
| @test current_task().sticky == true |
There was a problem hiding this comment.
Seems like it would be better to compare threadid() to check that they're the same.
vchuravy
commented
Jun 25, 2021
51 tasks
|
FYI I wrote #41393 which adds a bit more code but can unstick the parent |
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
vtjnash
approved these changes
Jun 29, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jun 30, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
vtjnash
added a commit
that referenced
this pull request
Oct 21, 2021
The `_wait2` function is similar to calling `schedule + wait` from another `@async` task, but optimized, so we want to observe the same side-effects of making the task sticky to the correct thread (and not accidentally making it sticky to the later task that handles the event). Refs #41334 (75858d7)
DilumAluthge
pushed a commit
that referenced
this pull request
Oct 22, 2021
The `_wait2` function is similar to calling `schedule + wait` from another `@async` task, but optimized, so we want to observe the same side-effects of making the task sticky to the correct thread (and not accidentally making it sticky to the later task that handles the event). Refs #41334 (75858d7) Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Oct 22, 2021
The `_wait2` function is similar to calling `schedule + wait` from another `@async` task, but optimized, so we want to observe the same side-effects of making the task sticky to the correct thread (and not accidentally making it sticky to the later task that handles the event). Refs #41334 (75858d7) Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com> (cherry picked from commit 6420885)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
The `_wait2` function is similar to calling `schedule + wait` from another `@async` task, but optimized, so we want to observe the same side-effects of making the task sticky to the correct thread (and not accidentally making it sticky to the later task that handles the event). Refs JuliaLang#41334 (75858d7) Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
The `_wait2` function is similar to calling `schedule + wait` from another `@async` task, but optimized, so we want to observe the same side-effects of making the task sticky to the correct thread (and not accidentally making it sticky to the later task that handles the event). Refs JuliaLang#41334 (75858d7) Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41324 for 1.7