Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Task smaller by rearranging fields #41351

Merged
merged 1 commit into from
Jun 28, 2021
Merged

make Task smaller by rearranging fields #41351

merged 1 commit into from
Jun 28, 2021

Conversation

JeffBezanson
Copy link
Member

This makes jl_task_t 8 bytes smaller, moving it into the next-smallest pool, which drops the effective size from 400 to 368 bytes.

This makes jl_task_t 8 bytes smaller, moving it into the next-smallest
pool, which drops the effective size from 400 to 368 bytes.
@oscardssmith
Copy link
Member

While you're moving things, should the pointers go after the rng state since on 32 bit systems they're only 4 bytes?

@JeffBezanson
Copy link
Member Author

On my 32-bit system the uint64 fields seem to be ok with an alignment of 4, so unfortunately it looks like we can't get a similar win there.

@JeffBezanson JeffBezanson merged commit af4bbfd into master Jun 28, 2021
@JeffBezanson JeffBezanson deleted the jb/tasksize branch June 28, 2021 22:30
KristofferC pushed a commit that referenced this pull request Jun 30, 2021
This makes jl_task_t 8 bytes smaller, moving it into the next-smallest
pool, which drops the effective size from 400 to 368 bytes.

(cherry picked from commit af4bbfd)
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
This makes jl_task_t 8 bytes smaller, moving it into the next-smallest
pool, which drops the effective size from 400 to 368 bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants