Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SHA to be an external stdlib #41370

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Move SHA to be an external stdlib #41370

merged 1 commit into from
Sep 14, 2021

Conversation

staticfloat
Copy link
Member

For the past few years, we have had SHA as a vendored copy, however
improvements have been made both to the vendored copy here in base as
well as to the registered copy living within JuliaCrypto. This
eliminates the vendored copy and sets SHA up as an external stdlib
just like Pkg, Tar, and all of their friends, as well as merges the
improvements made to both into the external repository.

@staticfloat staticfloat mentioned this pull request Jun 26, 2021
Closed
@DilumAluthge
Copy link
Member

Any particular reason for moving the GIT_URL and TAR_URL variables?

@DilumAluthge
Copy link
Member

Also, it looks like you need to commit the checksums, specifically deps/checksums/SHA-7ac490dfa78449ae81354cff9471a317f211a8f6.tar.gz/stdlib/SHA-7ac490dfa78449ae81354cff9471a317f211a8f6/.

@staticfloat
Copy link
Member Author

Any particular reason for moving the GIT_URL and TAR_URL variables?

It makes sense to have all the stdlib-specific stuff in their own files.

@DilumAluthge
Copy link
Member

Makes sense to me.

Can you ping me when you merge this PR? I'll need to update the BumpStdlibs.jl bot to account for the new locations of the GIT_URL and TAR_URL variables.

@DilumAluthge DilumAluthge added the stdlib Julia's standard library label Jul 8, 2021
@staticfloat staticfloat mentioned this pull request Jul 9, 2021
Closed
@staticfloat
Copy link
Member Author

This PR is hung up on #41528, as it breaks CI by triggering a new internal bug.

@vtjnash
Copy link
Member

vtjnash commented Jul 9, 2021

The contrib/new-stdlib.sh script probably should also be updated to write these values to the new location

@DilumAluthge
Copy link
Member

Could we break this PR up into two separate parts? With one part doing only the "make SHA an external stdlib", and a separate PR doing the "new locations of the GIT_URL and TAR_URL variables"?

@staticfloat
Copy link
Member Author

Okay, I rebased and dropped the second commit.

@staticfloat staticfloat mentioned this pull request Sep 8, 2021
Merged
@staticfloat
Move SHA to be an external stdlib
d0f0d10 
For the past few years, we have had `SHA` as a vendored copy, however
improvements have been made both to the vendored copy here in base as
well as to the registered copy living within `JuliaCrypto`.  This
eliminates the vendored copy and sets `SHA` up as an external stdlib
just like `Pkg`, `Tar`, and all of their friends, as well as merges the
improvements made to both into the external repository.
@staticfloat
Copy link
Member Author

Rebased on latest master, let's see if we pass tests on linux32 now.

@staticfloat staticfloat merged commit 2f47dae into master Sep 14, 2021
@staticfloat staticfloat deleted the sf/external_sha branch September 14, 2021 15:52
@DilumAluthge DilumAluthge mentioned this pull request Oct 2, 2021
Merged
@Seelengrab Seelengrab mentioned this pull request Oct 4, 2021
Closed
inkydragon added a commit to inkydragon/SHA.jl that referenced this pull request Oct 20, 2021
@inkydragon
[doc] cherry-pick index.md
39ae06d 
rm in JuliaLang/julia#41370

file history:
https://github.com/JuliaLang/julia/commits/0de41e27703768cfb8036db680d54cdf8175ba9f/stdlib/SHA/docs/src/index.md
staticfloat pushed a commit to JuliaCrypto/SHA.jl that referenced this pull request Oct 20, 2021
@inkydragon @staticfloat
[doc] cherry-pick index.md
7be6657 
rm in JuliaLang/julia#41370

file history:
https://github.com/JuliaLang/julia/commits/0de41e27703768cfb8036db680d54cdf8175ba9f/stdlib/SHA/docs/src/index.md
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@staticfloat @LilithHafner
Move SHA to be an external stdlib (JuliaLang#41370)
7f9828d 
For the past few years, we have had `SHA` as a vendored copy, however
improvements have been made both to the vendored copy here in base as
well as to the registered copy living within `JuliaCrypto`.  This
eliminates the vendored copy and sets `SHA` up as an external stdlib
just like `Pkg`, `Tar`, and all of their friends, as well as merges the
improvements made to both into the external repository.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@staticfloat @LilithHafner
Move SHA to be an external stdlib (JuliaLang#41370)
bce3951 
For the past few years, we have had `SHA` as a vendored copy, however
improvements have been made both to the vendored copy here in base as
well as to the registered copy living within `JuliaCrypto`.  This
eliminates the vendored copy and sets `SHA` up as an external stdlib
just like `Pkg`, `Tar`, and all of their friends, as well as merges the
improvements made to both into the external repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staticfloat @DilumAluthge @vtjnash