Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPFR tests: skip the log2(x) == log2(42) test #41473

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jul 5, 2021

Closes #41417

See also: #41450

test/mpfr.jl Outdated Show resolved Hide resolved
@simeonschaub simeonschaub requested a review from aviatesk July 5, 2021 21:12
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
@DilumAluthge DilumAluthge requested a review from simeonschaub July 5, 2021 21:17
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Jul 5, 2021
@DilumAluthge DilumAluthge marked this pull request as ready for review July 5, 2021 21:21
@DilumAluthge DilumAluthge changed the title MPFR tests: mark the log2(x) == log2(42) test as broken on Windows MPFR tests: skip the log2(x) == log2(42) test Jul 5, 2021
@DilumAluthge DilumAluthge merged commit fee5711 into master Jul 5, 2021
@DilumAluthge DilumAluthge deleted the dpa/mpfr-test-broken-windows branch July 5, 2021 23:19
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jul 6, 2021
KristofferC pushed a commit that referenced this pull request Jul 6, 2021
* MPFR tests: mark the `log2(x) == log2(42)` test as broken on Windows

* Apply suggestions from code review

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
(cherry picked from commit fee5711)
KristofferC pushed a commit that referenced this pull request Jul 6, 2021
* MPFR tests: mark the `log2(x) == log2(42)` test as broken on Windows

* Apply suggestions from code review

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
(cherry picked from commit fee5711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in testset mpfr
3 participants