Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: inference: fix #41450, replace constant-folded muladd with fma #41564

Closed
wants to merge 2 commits into from
Closed

wip: inference: fix #41450, replace constant-folded muladd with fma #41564

wants to merge 2 commits into from

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Jul 13, 2021 •
edited
Loading

So that we can get more accurate results where performance doesn't matter.

Followed @Keno 's comment here

@aviatesk aviatesk requested a review from Keno July 13, 2021 07:33
@aviatesk aviatesk mentioned this pull request Jul 13, 2021
Closed
@aviatesk aviatesk force-pushed the avi/41450 branch 2 times, most recently from 4f3b1ae to 6d0b5b3 Compare July 13, 2021 10:21
aviatesk added 2 commits July 13, 2021 21:42
@aviatesk
inference: fix #41450, replace constant-folded muladd with fma
65e3e7b 
So that we can get more accurate results when performance doesn't matter
@aviatesk
use libm for fma on Windows
ba8d629
@Keno
Copy link
Member

Keno commented Jul 13, 2021

Actually, muladd is not allowed to infer to Const at inference time (though it is allowed to be folded at optimization time), for precisely this reason. If we were doing that before that's a bug.

vtjnash
vtjnash requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this might be better to build on top of Keno's #31193 instead

@aviatesk aviatesk changed the title inference: fix #41450, replace constant-folded muladd with fma wip: inference: fix #41450, replace constant-folded muladd with fma Jul 13, 2021
@aviatesk aviatesk marked this pull request as draft July 13, 2021 16:51
@vtjnash vtjnash closed this Aug 24, 2021
@aviatesk aviatesk deleted the avi/41450 branch August 24, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash requested changes

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviatesk @Keno @vtjnash