-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAN improvements #41675
ASAN improvements #41675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify the CI script contrib/asan/
now a bit. It's useful for testing __asan_default_options
works. I just pushed my suggestion directly to the PR. I tested locally and it works for me.
It looks like the CI result will show up here: https://buildkite.com/julialang/julia-master-experimental/builds/222
Yeah, if you want to see the CI logs for the |
I'm a bit hesitant to support backporting too many things in the middle of the release hustle. But maybe it can be treated as a bug fix? Anyway, if we backport this, #41522 should go in, too, for updating LBT. |
We could always backport it to 1.7.1, right? Or any other future 1.7.x release? |
Anyway, I'll take the backport label off for now. |
No need, and it would require a backport of #41522 too. |
julia.h
, which isn't included by the loader. I've put them intoplatform.h
NO_RTLD
environment variable that's needed for LBT to work under ASAN. Not pretty, but makes a sanitized executable work out-of-the-box without having to set stuff in your environment.May be worth backporting to 1.7 to get a better ASAN experience there.