Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINSIGSTKSZ is no longer constant in glibc #41860

Merged
merged 1 commit into from
Aug 12, 2021
Merged

MINSIGSTKSZ is no longer constant in glibc #41860

merged 1 commit into from
Aug 12, 2021

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Aug 10, 2021 •
edited
Loading

MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34.

Fix #41806.

vtjnash
vtjnash requested changes Aug 11, 2021
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment mentions, we've seen empirically that this value is often too small. If we are removing the compile-time check here, we need to add it back as a runtime-check when we use the value.

@t-bltg
MINSIGSTKSZ is no longer constant in glibc
8f560f4 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34
@t-bltg t-bltg requested a review from vtjnash August 11, 2021 18:21
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Aug 11, 2021
@JeffBezanson JeffBezanson merged commit f19b9a2 into JuliaLang:master Aug 12, 2021
@t-bltg t-bltg deleted the minsigstksz branch August 12, 2021 20:18
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Aug 25, 2021
@tpapp tpapp mentioned this pull request Nov 2, 2021
Closed
@vtjnash vtjnash added backport 1.7 backport 1.6 Change should be backported to release-1.6 labels Nov 2, 2021
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
@t-bltg @KristofferC
MINSIGSTKSZ is no longer constant in glibc (#41860)
4b8fba2 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
@t-bltg @KristofferC
MINSIGSTKSZ is no longer constant in glibc (#41860)
7783a39 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
This was referenced Nov 7, 2021
Merged
Merged
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@t-bltg @KristofferC
MINSIGSTKSZ is no longer constant in glibc (#41860)
40f2d8e 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
@t-bltg @KristofferC
MINSIGSTKSZ is no longer constant in glibc (#41860)
09a49c6 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@t-bltg @LilithHafner
MINSIGSTKSZ is no longer constant in glibc (JuliaLang#41860)
f014b1b 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@t-bltg @LilithHafner
MINSIGSTKSZ is no longer constant in glibc (JuliaLang#41860)
54da442 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@t-bltg @staticfloat
MINSIGSTKSZ is no longer constant in glibc (#41860)
177cf61 
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MINSIGSTKSZ is no longer a constant on Linux
5 participants
@t-bltg @vtjnash @JeffBezanson @KristofferC @DilumAluthge