Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BinaryBuilder libuv to 2.0.1+4 #41900

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Update BinaryBuilder libuv to 2.0.1+4 #41900

merged 1 commit into from
Aug 18, 2021

Conversation

ararslan
Copy link
Member

The FreeBSD binaries for this build are built with FreeBSD 12 rather than FreeBSD 11, which will work around #34627 now that support for FreeBSD 11 has been officially discontinued. Before closing that issue I'd like to verify whether binaries built for FreeBSD 12 will work on 13 so that I don't have a copy-paste a new issue with 11 and 12 incremented to 12 and 13. 😄

Note that the FreeBSD buildbot won't notice this change since we have it set to build with USE_BINARYBUILDER_LIBUV=0 specifically to work around #34627. Once this is merged, it would be nice if we could figure out a way to conditionally set that flag.

@ararslan ararslan added system:freebsd Affects only FreeBSD external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Aug 17, 2021
@DilumAluthge
Copy link
Member

Sounds good to me. Probably good to have Elliot sign off on this as well before merging.

@DilumAluthge
Copy link
Member

Note that the FreeBSD buildbot won't notice this change since we have it set to build with USE_BINARYBUILDER_LIBUV=0 specifically to work around #34627. Once this is merged, it would be nice if we could figure out a way to conditionally set that flag.

Not sure how to do this with Buildbot, but when we switch to Buildkite, we can condition the flag based on which branch is being built (master, release-1.6, release-1.7, etc.).

@ararslan
Copy link
Member Author

The FreeBSD CI failure is

ERROR: The working directory is dirty.
Output of git status:
On branch refs/pull/41900/merge
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	base/Artifacts.toml
	base/load_artifact.jl

which I've not observed locally.

@ararslan
Copy link
Member Author

Also Julia now builds successfully on FreeBSD 13 without setting USE_BINARYBUILDER_LIBUV=0, so I think this PR effectively fixes #34627.

@ararslan
Copy link
Member Author

Rebased to see whether that fixes anything, since I can't reproduce.

@ararslan
Copy link
Member Author

The buildkite stuff is failing with

ERROR: "/cache/julia-buildkite-plugin/depots/53de1ea5-6dd3-4008-b976-161c9f34b0ad/registries/General/J/JLLWrappers/Package.toml": No such file

@ararslan
Copy link
Member Author

ararslan commented Aug 18, 2021 •
edited
Loading

I restarted the FreeBSD buildbots and the build passed successfully. I don't expect the tests to pass at the moment (for reasons unrelated to this PR).

@ararslan
Update BinaryBuilder libuv to 2.0.1+4
051ccf9 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue 34627.
@ararslan
Copy link
Member Author

Summary of CI failures, all of which appear unrelated to this PR:

  • Windows x86 tests: Failure in spawn: 
    LoadError: Failed to connect to cache.julialang.org port 443: Timed out while requesting https://cache.julialang.org/https://frippery.org/files/busybox/busybox.exe
  • Windows x64 tests: Failure in spawn: 
    LoadError: Failed to connect to cache.julialang.org port 443: Timed out while requesting https://cache.julialang.org/https://frippery.org/files/busybox/busybox.exe
  • Linux x86 tests: Failure in cmdlineargs: 
    Error During Test at /buildworker/worker/tester_linux32/build/share/julia/test/cmdlineargs.jl:202
Test threw exception
Expression: string(cpu_threads) == read(`$exename --threads auto -e $code`, String) == read(`$exename --threads=auto -e $code`, String) == read(`$exename -tauto -e $code`, String) == read(`$exename -t auto -e $code`, String)
failed process: Process(`/buildworker/worker/tester_linux32/build/bin/julia -Cnative -J/buildworker/worker/tester_linux32/build/lib/julia/sys.so --depwarn=error --check-bounds=yes -g1 --startup-file=no --startup-file=no --color=no --threads auto -e 'print(Threads.nthreads())'`, ProcessExited(1)) [1]
  • Linux PPC build: OOM while building the sysimage 
    /bin/sh: line 1: 146626 Killed                  JULIA_BINDIR=/buildworker/worker/package_linuxppc64le/build/usr/bin WINEPATH="/buildworker/worker/package_linuxppc64le/build/usr/bin;$WINEPATH" /buildworker/worker/package_linuxppc64le/build/usr/bin/julia -O3 -C "pwr8" --output-o /buildworker/worker/package_linuxppc64le/build/usr/lib/julia/sys-o.a.tmp --startup-file=no --warn-overwrite=yes --sysimage /buildworker/worker/package_linuxppc64le/build/usr/lib/julia/sys.ji /buildworker/worker/package_linuxppc64le/build/contrib/generate_precompile.jl 1
make[1]: *** [/buildworker/worker/package_linuxppc64le/build/usr/lib/julia/sys-o.a] Error 1
make: *** [julia-sysimg-release] Error 2
  • FreeBSD x64 tests:
    • Sockets failure (known, introduced by add stream shutdown and support half-duplex operation #40783) 
      Test Failed at /usr/home/julia/buildbot/w2_tester/tester_freebsd64/build/share/julia/stdlib/v1.8/Sockets/test/runtests.jl:524
  Expression: !(isopen(P))
    • Workers killed by a sneaky segfault (known, under investigation) 
      UNHANDLED TASK ERROR: EOFError: read end of file
    • Sigterm due to tests hanging (known, under investigation and likely due to the aforementioned segfaults) 
      signal (15): Terminated
in expression starting at /usr/home/julia/buildbot/w2_tester/tester_freebsd64/build/share/julia/test/runtests.jl:93

@vtjnash vtjnash merged commit 5e1670e into master Aug 18, 2021
@vtjnash vtjnash deleted the aa/freebsd-libuv branch August 18, 2021 20:50
@ararslan ararslan added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 6, 2021
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
@ararslan @KristofferC
Update BinaryBuilder libuv to 2.0.1+4 (#41900)
5830b81 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue #34627.

(cherry picked from commit 5e1670e)
This was referenced Nov 7, 2021
Merged
Merged
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
@ararslan @KristofferC
Update BinaryBuilder libuv to 2.0.1+4 (#41900)
40b53d3 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue #34627.

(cherry picked from commit 5e1670e)
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
@ararslan @KristofferC
Update BinaryBuilder libuv to 2.0.1+4 (#41900)
b7b9c15 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue #34627.

(cherry picked from commit 5e1670e)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@ararslan @KristofferC
Update BinaryBuilder libuv to 2.0.1+4 (#41900)
2fc24ea 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue #34627.

(cherry picked from commit 5e1670e)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
@ararslan @KristofferC
Update BinaryBuilder libuv to 2.0.1+4 (#41900)
7524cdd 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue #34627.

(cherry picked from commit 5e1670e)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
@ararslan ararslan mentioned this pull request Nov 18, 2021
Merged
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@ararslan @LilithHafner
Update BinaryBuilder libuv to 2.0.1+4 (JuliaLang#41900)
2ada675 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue JuliaLang#34627.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@ararslan @LilithHafner
Update BinaryBuilder libuv to 2.0.1+4 (JuliaLang#41900)
81cfc61 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue JuliaLang#34627.
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@ararslan @staticfloat
Update BinaryBuilder libuv to 2.0.1+4 (#41900)
9e7f160 
The FreeBSD binaries for this build are built with FreeBSD 12 rather
than FreeBSD 11, which will work around issue #34627.

(cherry picked from commit 5e1670e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:freebsd Affects only FreeBSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ararslan @DilumAluthge @vtjnash @KristofferC