Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recommend explicit using Foo: Foo, ... in package code (was: "using considered harmful") #42080

Merged
merged 13 commits into from
Oct 26, 2024
Merged

recommend explicit using Foo: Foo, ... in package code (was: "using considered harmful") #42080

merged 13 commits into from
Oct 26, 2024

Commits on Sep 1, 2021

  1. warn against using Foo in package code

    @KristofferC
    KristofferC committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c2e519b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'master' into kc/warn_using

    @DilumAluthge
    DilumAluthge authored May 24, 2024
    Configuration menu
    Copy the full SHA
    f8a4c54 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Add guidance for using qualified names in packages (#53428) 

    Note: the base branch (target branch) of this PR is `kc/warn_using`
(#42080), NOT `master`.

---

This is additive to #42080 which
adds advice to the docstring of `using` .

The wording here is a tweaked version of @IanButterworth's suggestion
here:
#42080 (comment)

---------

Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
    @MasonProtter @fingolfin @DilumAluthge
    3 people authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5a497c8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kc/warn_using

    @DilumAluthge
    DilumAluthge authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    eb9c668 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Unify some of the language from #53428

    @mbauman
    mbauman authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    aa0ce07 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. make shorter

    @KristofferC
    KristofferC authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ca82f8b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Update base/docs/basedocs.jl 

    Co-authored-by: Alex Arslan <ararslan@comcast.net>
    @KristofferC @ararslan
    KristofferC and ararslan authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d99b8d1 View commit details
    Browse the repository at this point in the history

  2. Update doc/src/manual/modules.md 

    Co-authored-by: Alex Arslan <ararslan@comcast.net>
    @KristofferC @ararslan
    KristofferC and ararslan authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    990cd5c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'master' into kc/warn_using

    @DilumAluthge
    DilumAluthge authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9cdfc27 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Update doc/src/manual/modules.md 

    Co-authored-by: Alex Arslan <ararslan@comcast.net>
    @IanButterworth @ararslan
    IanButterworth and ararslan authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cd7e39b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kc/warn_using

    @IanButterworth
    IanButterworth authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8d7a183 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Neven Sajko <s@purelymail.com>
    @IanButterworth @nsajko
    IanButterworth and nsajko authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    402d284 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'master' into kc/warn_using

    @DilumAluthge
    DilumAluthge authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8b4ae86 View commit details
    Browse the repository at this point in the history