Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faster hypot for Float32 and Float16 #42122

Merged
merged 6 commits into from
Nov 10, 2021
Merged

faster hypot for Float32 and Float16 #42122

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
692d567
faster hypot for Float32 and Float16
Moelf Sep 5, 2021
18499b7
make mobile less sucky
Moelf Sep 5, 2021
c5d3cd6
move fastmath earlier
Moelf Sep 5, 2021
4f512ce
clean up and add inf
Moelf Sep 6, 2021
0ba3c7c
muladd and clean up
Moelf Sep 6, 2021
cb9bb07
fix for inf
Moelf Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion base/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,14 @@ function _hypot(x, y)
end
return h*scale*oneunit(axu)
end
_hypot(x::Float16, y::Float16) = Float16(_hypot(Float32(x), Float32(y)))
@inline function _hypot(x::Float32, y::Float32)
_x, _y = Float64(x), Float64(y)
return Float32(sqrt(muladd(_x, _x, _y*_y)))
end
@inline function _hypot(x::Float16, y::Float16)
_x, _y = Float32(x), Float32(y)
return Float16(sqrt(muladd(_x, _x, _y*_y)))
end
_hypot(x::ComplexF16, y::ComplexF16) = Float16(_hypot(ComplexF32(x), ComplexF32(y)))

function _hypot(x...)
Expand Down