Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.7: set VERSION to 1.7.0-rc1 #42188

Merged
merged 1 commit into from
Sep 12, 2021
Merged

release-1.7: set VERSION to 1.7.0-rc1 #42188

merged 1 commit into from
Sep 12, 2021

Conversation

KristofferC
Copy link
Member

No description provided.

@KristofferC KristofferC added the release Release management and versioning. label Sep 9, 2021
@KristofferC
Copy link
Member Author

Should probably fix #42150 first.

@PallHaraldsson
Copy link
Contributor

It seems #42201 isn't in (its issue on 1.7 milestone) release-1.7 branch, and should, even though you force-pushed.

@KristofferC
Copy link
Member Author

I didn't really understand that.

@aviatesk
Copy link
Member

@KristofferC how should we backport #42125 into release-1.7 ?

@KristofferC
Copy link
Member Author

To me that looks like a feature and is pretty late for the feature freeze. Am I wrong in that?

@aviatesk
Copy link
Member

Yes, it certainly adds new features (enable constant-prop' to be disabled). But the reason why we want to backport it is that it generalizes and renames @aggressive_constprop, which was introduced in v1.7, and we don't want to release @aggressive_constprop into the wild.

/cc @timholy

@KristofferC
Copy link
Member Author

@aggressive_constprop already looks used in the wild and it is internal anyway. And it doesn't seem hard to silently deprecate @aggresive_constpropinto @constprop :aggressive?

@timholy
Copy link
Member

timholy commented Sep 11, 2021

I can easily make PRs against the 6 known packages that use @aggressive_constprop, but I'm fine either way. There's already Compat.@constprop which implements the new interface on Julias that have @aggressive_constprop.

EDIT: trial balloon at JuliaArrays/ArrayInterface.jl#205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants