Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix verifier to allow GlobalRef as assignment RHS #42417

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix verifier to allow GlobalRef as assignment RHS #42417

merged 1 commit into from
Sep 29, 2021

Conversation

JeffBezanson
Copy link
Member

Found while working on #42409. The verifier treats an assignment RHS as a normal value use, which is typically correct, but I believe it is ok for an undefined GlobalRef to be present there, unlike other value contexts.

@vtjnash vtjnash added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 29, 2021
@vtjnash
Copy link
Member

vtjnash commented Sep 29, 2021

From linux64 (with rr), if anyone cares:

LinearAlgebra/tridiag              (7) |        started at 2021-09-28T20:34:34.288 on pid 30957
      From worker 7:	
      From worker 7:	signal (11): Segmentation fault
      From worker 7:	in expression starting at /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.8/LinearAlgebra/test/tridiag.jl:28
      From worker 7:	slarrv_64_ at /buildworker/worker/tester_linux64/build/bin/../lib/julia/libopenblas64_.so (unknown line)
      From worker 7:	sstemr_64_ at /buildworker/worker/tester_linux64/build/bin/../lib/julia/libopenblas64_.so (unknown line)
      From worker 7:	sstegr_64_ at /buildworker/worker/tester_linux64/build/bin/../lib/julia/libopenblas64_.so (unknown line)
      From worker 7:	stegr! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/lapack.jl:3853
      From worker 7:	eigen! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/tridiag.jl:294 [inlined]
      From worker 7:	eigen at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/tridiag.jl:296
      From worker 7:	unknown function (ip: 0x7f226384f2f0)

@vtjnash vtjnash merged commit 3bcdd87 into master Sep 29, 2021
@vtjnash vtjnash deleted the jb/verifyglobalrefrhs branch September 29, 2021 15:04
@andreasnoack
Copy link
Member

The segfault is tracked in JuliaLang/LinearAlgebra.jl#873

KristofferC pushed a commit that referenced this pull request Oct 5, 2021
@JeffBezanson @KristofferC
fix verifier to allow GlobalRef as assignment RHS (#42417)
fef46d5 
(cherry picked from commit 3bcdd87)
@KristofferC KristofferC mentioned this pull request Oct 5, 2021
Merged
84 tasks
KristofferC pushed a commit that referenced this pull request Oct 19, 2021
@JeffBezanson @KristofferC
fix verifier to allow GlobalRef as assignment RHS (#42417)
f7103b8 
(cherry picked from commit 3bcdd87)
@KristofferC KristofferC mentioned this pull request Oct 19, 2021
Merged
95 tasks
@KristofferC KristofferC mentioned this pull request Nov 8, 2021
Merged
66 tasks
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@JeffBezanson @KristofferC
fix verifier to allow GlobalRef as assignment RHS (#42417)
1c8a1d1 
(cherry picked from commit 3bcdd87)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@JeffBezanson @LilithHafner
fix verifier to allow GlobalRef as assignment RHS (JuliaLang#42417)
9ffc07f
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@JeffBezanson @LilithHafner
fix verifier to allow GlobalRef as assignment RHS (JuliaLang#42417)
fce0622
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@JeffBezanson @staticfloat
fix verifier to allow GlobalRef as assignment RHS (#42417)
59712f4 
(cherry picked from commit 3bcdd87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @vtjnash @andreasnoack @KristofferC